Re: [PATCH v6 1/2] dt-bindings: media: i2c: Add ov2735 sensor
From: Hardevsinh Palaniya
Date: Thu Jul 31 2025 - 03:10:33 EST
> On 31/07/2025 08:36, Hardevsinh Palaniya wrote:
> > > On 31/07/2025 08:09, Hardevsinh Palaniya wrote:
> > > > + properties:
> > > > + data-lanes:
> > > > + items:
> > > > + - const: 1
> > > > + - const: 2
> > > > + link-frequencies: true
> > > Nothing improved. My comments from versions before still apply.
> >
> > I asked you in v4, but you didn’t respond.
> >
> > Could you please check?
> >
> > Link:https://lore.kernel.org/linux-media/PN3P287MB351999B4DB533CCA9C6E6567FF51A@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
> >
> > The driver will always rely on the device tree for the link frequency.
> > Without it, the driver will fail to probe.
>
> How is it related? I did not ask to remove it from the driver.
>
> >
> > So, the bindings need this property, just like other camera sensors do.
> The property is already there, you just duplicated it. You added
> completely redundant code and instead of ACTUALLY TESTING YOUR DTS you
> keep disagreeing.
Okay, I understand now, the link-frequencies property is already defined in
the video-interfaces.yaml reference, so there’s no need to explicitly add it
again in the sensor binding.
Apologies for repeatedly disagreeing earlier. In your previous response, it
was a little hard to understand that you were saying the property is already
there and being duplicated.
Best Regards,
Hardev