Re: [PATCH net-next v4 0/4] net: add local address bind support to vxlan and geneve

[Richard Gobert]

Ido Schimmel wrote:
> On Thu, Jul 17, 2025 at 01:54:08PM +0200, Richard Gobert wrote:
>> This series adds local address bind support to both vxlan
>> and geneve sockets.
> 
> A few comments:
> 
> 1. Binding the VXLAN socket to the local address does break
> functionality. Run the VXLAN selftests in tools/testing/selftests/net/
> and you will see failures. IOW, you cannot change the default behavior.
Missed the failing tests. Will be fixed in the next revision.

> You might not need the first patch if the new behavior is opt-in rather
> than opt-out.
This patch allows the localbind option to be set while the outgoing
interface is down. IMO, it is desirable.

> 
> 2. Please add a selftest for the new functionality. See the existing
> VXLAN selftests for reference. There is no need to wait for the iproute2
> patch to be accepted. You can have a check to skip the test if iproute2
> does not have the required functionality.
Do you think adding a new test that verifies that the localbind option
works would be sufficient?

> 
> 3. The cover letter should explain the motivation for these patches.
> Currently it only explains what the patches do.
Noted. Will write a better cover letter once all other issues are resolved.