Re: [PATCH] selftests: timers: improve adjtick output readability

From: Vishal Parmar
Date: Thu Jul 31 2025 - 12:13:02 EST


hi Thomas,

> Please do not top-post and trim your replies.
Thanks, I learned about this netiquette today.
I hope this reply is in the correct format.

> The point John was making:
>
> >> So it might be worth looking into getting the output to be happy with
> >> TAP while you're tweaking things here.
>
> The kernel selftests are converting over to standardized TAP output
> format, which is intended to aid automated testing.
>
> So if we change the outpot format of this test, then we switch it over to
> TAP format and do not invent yet another randomized output scheme.

oh okay, please ignore this patch. no need to review it further.

> For the success case, the actual numbers are uninteresting. In the
> failure case it's sufficient to emit:
>
> ksft_test_result_fail("Req: NNNN, Exp: $MMMM, Res: $LLLL\n", ...);
>
> In case of regressions (fail), a report providing this output is good
> enough for the relevant maintainer/developer to start investigating
> No?

yes understood, thanks for the explanation.

Thanks,
Vishal