Re: [PATCH v2 3/5] verification/rvgen/ltl: Support per-cpu monitor generation

[Nam Cao]

Gabriele Monaco <gmonaco@xxxxxxxxxx> writes:
> I get you're trying to be more type-agnostic, but I believe this
> /online/ is a bit imprecise, unless you register a hotplug handler and
> just initialise the online CPUs (much of an overkill I'd say).
> What about something like "this is false if the monitor exists already
> before the monitor is enabled"

Sorry, after re-reading this one day later, I am still not sure why you
says "online" is imprecise. Due to hotplug, CPUs can become online and
offline.

The current implementation ignore hotplug and initialize all possible
CPUs as if they are all oneline. But if hotplug becomes important in the
future, I may add a CPU hotplug handler.

> Other than that it looks good to me.
>
> Reviewed-by: Gabriele Monaco <gmonaco@xxxxxxxxxx>

Thanks!

Nam