Re: [PATCH 2/4] PCI/MSI: Add startup/shutdown support for per device MSI[X] domains

From: Thomas Gleixner
Date: Mon Aug 11 2025 - 10:32:01 EST


On Fri, Aug 08 2025 at 07:18, Inochi Amaoto wrote:
> On Thu, Aug 07, 2025 at 11:25:21AM -0500, Bjorn Helgaas wrote:
>> >
>> > +static __always_inline void cond_shutdown_parent(struct irq_data *data)
>>
>> Is there a functional reason why we need __always_inline?
>>
> I am not sure for this. As I found other cond_[mask/unmask]_parent()
> also have this attribute, I added this as well.
>
>> If not, it seems like this annotation is just clutter, and the compiler
>> will probably inline it all by itself.

Most of the time, but yes in this case it's irrelevant.