Re: [PATCH net-next v5 2/5] net: spacemit: Add K1 Ethernet MAC

[Andrew Lunn]

> +/* Caller must hold stats_lock */
> +static void emac_stats_update(struct emac_priv *priv)
> +{
> +	u64 *tx_stats_off = (u64 *)&priv->tx_stats_off;
> +	u64 *rx_stats_off = (u64 *)&priv->rx_stats_off;
> +	u64 *tx_stats = (u64 *)&priv->tx_stats;
> +	u64 *rx_stats = (u64 *)&priv->rx_stats;
> +	u32 i, res;

Rather than the comment, you could do:

	assert_spin_locked(priv->stats_lock);

	Andrew