Re: [PATCH 2/3] dt-bindings: net: Add support for J-Core EMAC

[Krzysztof Kozlowski]

On 15/08/2025 21:48, Artur Rojek wrote:
> Add a documentation file to describe the Device Tree bindings for the
> Ethernet Media Access Controller found in the J-Core family of SoCs.
> 
> Signed-off-by: Artur Rojek <contact@xxxxxxxxxxxxxx>
> ---
>  .../devicetree/bindings/net/jcore,emac.yaml   | 42 +++++++++++++++++++
>  1 file changed, 42 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/jcore,emac.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/jcore,emac.yaml b/Documentation/devicetree/bindings/net/jcore,emac.yaml
> new file mode 100644
> index 000000000000..a4384f7ed83d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/jcore,emac.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/jcore,emac.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: J-Core Ethernet Media Access Controller
> +
> +description: |
> +  This node provides properties for configuring the Ethernet MAC found
> +  in the J-Core family of SoCs.
> +
> +maintainers:
> +  - Artur Rojek <contact@xxxxxxxxxxxxxx>
> +
> +properties:
> +  compatible:
> +    const: jcore,emac

You need SoC-based compatibles. And then also rename the file to match it.

> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +allOf:
> +  - $ref: ethernet-controller.yaml#
> +
> +additionalProperties: false

unevaluatedProperties instead

> +
> +examples:
> +  - |
> +    ethernet@10000 {
> +      compatible = "jcore,emac";
> +      reg = <0x10000 0x2000>;
> +      interrupts = <0x11>;

That's not hex...

> +    };


Best regards,
Krzysztof