Re: [PATCH 1/3] crypto: hisilicon/zip - support fallback for zip

[Herbert Xu]

On Sat, Aug 09, 2025 at 03:08:27PM +0800, Chenghai Huang wrote:
>
> +err_out:
> +	if (acomp_req->base.complete)
> +		acomp_request_complete(acomp_req, ret);

First of all you should never check acomp_req->base.complete.
It must be non-NULL for an async driver.

More importantly, you shouldn't even be invoking the callback
function here.  The callback is only to be called after an async
return with -EINPROGRESS.  Since this code path never returned an
-EINPROGRESS in the first place, it must not call the callback.

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt