Re: [PATCH v2] crypto: caam - switch to use devm_kmemdup_array()

[Herbert Xu]

On Wed, Jul 23, 2025 at 10:50:27AM +0800, zhang.enpei@xxxxxxxxxx wrote:
> From: Zhang Enpei <zhang.enpei@xxxxxxxxxx>
> 
> Use devm_kmemdup_array() to avoid multiplication or possible overflows.
> 
> Signed-off-by: Zhang Enpei <zhang.enpei@xxxxxxxxxx>
> ---
>  drivers/crypto/caam/ctrl.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c
> index ce7b99019537..2250dce9c344 100644
> --- a/drivers/crypto/caam/ctrl.c
> +++ b/drivers/crypto/caam/ctrl.c
> @@ -592,9 +592,9 @@ static int init_clocks(struct device *dev, const struct caam_imx_data *data)
>         int ret;
> 
>         ctrlpriv->num_clks = data->num_clks;
> -       ctrlpriv->clks = devm_kmemdup(dev, data->clks,
> -                                     data->num_clks * sizeof(data->clks[0]),
> -                                     GFP_KERNEL);
> +       ctrlpriv->clks = devm_kmemdup_array(dev, data->clks,
> +                                           data->num_clks, sizeof(*data->clks),
> +                                           GFP_KERNEL);
>         if (!ctrlpriv->clks)
>                 return -ENOMEM;

This patch doesn't apply because it is space-damaged.  Please
resubmit.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt