Re: [PATCH 1/3] dt-bindings: reset: Document reset controller of Loongson 2K0300 SoC

From: Yao Zi
Date: Sat Aug 16 2025 - 06:25:37 EST


On Sat, Aug 16, 2025 at 11:48:46AM +0200, Krzysztof Kozlowski wrote:
> On 16/08/2025 05:33, Yao Zi wrote:
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + rst: reset-controller@1600011c {
>
> Drop unused label
>
>
> > + compatible = "loongson,ls2k0300-reset";
> > + reg = <0x1600011c 0x8>;
> > + #reset-cells = <1>;
> > + };
> > diff --git a/include/dt-bindings/reset/loongson,ls2k0300-reset.h b/include/dt-bindings/reset/loongson,ls2k0300-reset.h
> > new file mode 100644
> > index 000000000000..d425411e6d19
> > --- /dev/null
> > +++ b/include/dt-bindings/reset/loongson,ls2k0300-reset.h
> > @@ -0,0 +1,70 @@
> > +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
>
> Why not using same license as the binding?

I was referring to another binding's header when writing this, and yes
it's better to keep them the same.

>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Will fix these issues and carry the tag in v2, thanks.

> Best regards,
> Krzysztof

Best regards,
Yao Zi