Re: [PATCH] iio: adc: ad7380: fix missing max_conversion_rate_hz on adaq4381-4

[Jonathan Cameron]

On Mon, 11 Aug 2025 21:22:28 +0200
Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:

> On Mon, Aug 11, 2025 at 9:18 PM David Lechner <dlechner@xxxxxxxxxxxx> wrote:
> > On 8/11/25 2:07 PM, Andy Shevchenko wrote:  
> > > On Mon, Aug 11, 2025 at 8:32 PM David Lechner <dlechner@xxxxxxxxxxxx> wrote:  
> 
> ...
> 
> > >> +       .max_conversion_rate_hz = 4 * MEGA,  
> > >
> > > MEGA --> HZ_PER_MHZ  
> >
> > If we do this, we should fix up all of the other similar ones
> > in a separate patch. So I would leave this patch as-is.  
> 
> Will it happen sooner?
> 
> > > With that done
> > > Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>  
> 
> I leave this to Jonathan because in spite of being a fix I still think
> it's better to use an appropriate multiplier (also note, MEGA appeared
> in the kernel much later than HZ_PER_* constants, which sounds in my
> favour).
> 

I'll take this as is.  A future tidy up might switch them all over.
I've always been in two minds as to whether the unit specific ones
are helpful for this case where one of the scales is 1.

Applied to the fixes-togreg branch of iio.git.

Jonathan