Re: [PATCH v1 2/2] arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE

[Dmitry Baryshkov]

On Fri, Aug 15, 2025 at 08:28:32PM -0300, Eric Gonçalves wrote:
> 
> 
> On August 15, 2025 19:03:20 GMT-03:00, Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx> wrote:
> >On Fri, Aug 15, 2025 at 03:14:26PM +0000, Eric Gonçalves wrote:
> >> Add new device support for the Samsung Galaxy S20 FE 4G/5G
> >>  (SM-G980/SM-G981B) phone
> >> 
> >> What works:
> >> - SimpleFB
> >> - Pstore/ramoops
> >
> >While the patch is correct, are there any obstacles in enabling more
> >devices on the phone? I'd say, buttons, remoteprocs, PCI and USB
> >peripherals should be low hanging fruits. If you can read pmic_array
> >from debugfs/qcom_socinfo, then you should be able to identify PMICs and
> >add corresponding regulators too.
> >
> >> Signed-off-by: Eric Gonçalves <ghatto404@xxxxxxxxx>
> >> ---
> >>  arch/arm64/boot/dts/qcom/Makefile             |  1 +
> >>  .../boot/dts/qcom/sm8250-samsung-r8q.dts      | 47 +++++++++++++++++++
> >>  2 files changed, 48 insertions(+)
> >>  create mode 100644 arch/arm64/boot/dts/qcom/sm8250-samsung-r8q.dts
> >
> Hello Dmitry,
> 
> Recently my device's battery stopped responding and I was not able to
> work on the DT any further, so I decided to upstream what I already
> have so far. Thanks for the feedback, I'll include more features on
> future patches.
> 

Thanks!

For this patch:

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>


-- 
With best wishes
Dmitry