Re: [net-next v3 1/3] dt-bindings: net: dsa: yt921x: Add Motorcomm YT921x switch support

[Andrew Lunn]

> +  motorcomm,switch-id:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: |
> +      When managed via MDIO, a hard-configured switch ID to form MDIO reg addrs,
> +      to distinguish between multiple devices beside phyaddr.
> +    enum: [0, 1, 2, 3]
> +    default: 0
> +    maxItems: 1

So how is this different to reg? Why cannot it be derived from reg?
Please give us all the details of what this actually does. Or point us
to a chapter in the datasheet.

> +                /* if external phy is connected to a MAC */
> +                port@9 {
> +                    reg = <9>;
> +                    label = "wan";
> +                    phy-mode = "rgmii";
> +                    phy-handle = <&phy1>;
> +
> +                    fixed-link {
> +                        speed = <1000>;
> +                        full-duplex;
> +                        pause;
> +                    };

If there is an external PHY, why have a fixed link?


    Andrew

---
pw-bot: cr