RE: [PATCH v7 02/13] PCI: cadence: Split PCIe controller header file

[Manikandan Karunakaran Pillai]

Thanks Bjorn for your comments. Will address your comments on patches 1 to patches 7, in the next submission

>-----Original Message-----
>From: Bjorn Helgaas <helgaas@xxxxxxxxxx>
>Sent: Friday, August 15, 2025 2:47 AM
>To: hans.zhang@xxxxxxxxxxx
>Cc: bhelgaas@xxxxxxxxxx; lpieralisi@xxxxxxxxxx; kw@xxxxxxxxx;
>mani@xxxxxxxxxx; robh@xxxxxxxxxx; kwilczynski@xxxxxxxxxx;
>krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; Manikandan Karunakaran Pillai
><mpillai@xxxxxxxxxxx>; fugang.duan@xxxxxxxxxxx;
>guoyin.chen@xxxxxxxxxxx; peter.chen@xxxxxxxxxxx; cix-kernel-
>upstream@xxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx;
>devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
>Subject: Re: [PATCH v7 02/13] PCI: cadence: Split PCIe controller header file
>
>EXTERNAL MAIL
>
>
>On Wed, Aug 13, 2025 at 12:23:20PM +0800, hans.zhang@xxxxxxxxxxx wrote:
>> From: Manikandan K Pillai <mpillai@xxxxxxxxxxx>
>>
>> Split the Cadence PCIe header file by moving the Legacy(LGA)
>> controller register definitions to a separate header file for
>> support of next generation PCIe controller architecture.
>
>s/Legacy(LGA)/Legacy (LGA)/
>
>Similar for "HPA(High Performance architecture)" elsewhere.
>
>> +++ b/drivers/pci/controller/cadence/pcie-cadence-lga-regs.h
>> @@ -0,0 +1,228 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +// Copyright (c) 2017 Cadence
>> +// Cadence PCIe controller driver.
>> +// Author: Manikandan K Pillai <mpillai@xxxxxxxxxxx>
>
>I'm not trying to be a killjoy, but the only author listed in
>pcie-cadence.h is Cyrille Pitchen, and I don't think simply moving
>these definitions to a separate file really counts as becoming the
>author.  I would at least preserve Cyrille's authorship.
>
>Bjorn