Re: [PATCH v2 14/24] media: iris: Add support for ENUM_FRAMESIZES/FRAMEINTERVALS for encoder

[Vikash Garodia]

On 8/18/2025 8:51 AM, Dikshita Agarwal wrote:
>>> diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/drivers/media/platform/qcom/iris/iris_platform_gen2.c
>>> index d3026b2bcb708c7ec31f134f628df7e57b54af4f..1e2fadfe17672029b46e07ce00a8e31e0711fd58 100644
>>> --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c
>>> +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c
>>> @@ -354,6 +354,7 @@ struct iris_platform_data sm8550_data = {
>>>  	.num_vpp_pipe = 4,
>>>  	.max_session_count = 16,
>>>  	.max_core_mbpf = NUM_MBS_8K * 2,
>>> +	.max_core_mbps = ((7680 * 4320) / 256) * 60,
>>>  	.input_config_params_default =
>>>  		sm8550_vdec_input_config_params_default,
>>>  	.input_config_params_default_size =
>>> @@ -429,6 +430,7 @@ struct iris_platform_data sm8650_data = {
>>>  	.num_vpp_pipe = 4,
>>>  	.max_session_count = 16,
>>>  	.max_core_mbpf = NUM_MBS_8K * 2,
>>> +	.max_core_mbps = ((7680 * 4320) / 256) * 60,
>>>  	.input_config_params_default =
>>>  		sm8550_vdec_input_config_params_default,
>>>  	.input_config_params_default_size =
>>> @@ -500,6 +502,7 @@ struct iris_platform_data qcs8300_data = {
>>>  	.num_vpp_pipe = 2,
>>>  	.max_session_count = 16,
>>>  	.max_core_mbpf = ((4096 * 2176) / 256) * 4,
>>> +	.max_core_mbps = ((7680 * 4320) / 256) * 60, //TODO confirm!!
>> TODO ? 4k@60 is supported mbps for qcs8300
> It was a miss, will remove the TODO.
> 

With that fixed..

Reviewed-by: Vikash Garodia <quic_vgarodia@xxxxxxxxxxx>