Re: [PATCH v2 2/3] arm64: dts: rockchip: remove vcc_3v3_pmu regulator for Radxa E52C

[FUKAUMI Naoki]

Hi Chukun,

On 8/16/25 17:00, Chukun Pan wrote:
> According to Radxa E52C Schematic V1.2 [1] page 5, vcc_3v3_pmu
> is directly connected to vcc_3v3_s3 via a 0 ohm resistor.
> The vcc_3v3_pmu is not a new regulator, so remove it.
>
> [1] https://dl.radxa.com/e/e52c/hw/radxa_e52c_v1.2_schematic.pdf
>
> Signed-off-by: Chukun Pan <amadeus@xxxxxxxxxx>
> ---
>   arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts | 12 +-----------
>   1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> index 1883bd183396..4a3ae95f122f 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> @@ -98,16 +98,6 @@ vcc_1v1_nldo_s3: regulator-1v1 {
>   		vin-supply = <&vcc_sysin>;
>   	};
>   
> -	vcc_3v3_pmu: regulator-3v3-0 {
> -		compatible = "regulator-fixed";
> -		regulator-name = "vcc_3v3_pmu";
> -		regulator-always-on;
> -		regulator-boot-on;
> -		regulator-min-microvolt = <3300000>;
> -		regulator-max-microvolt = <3300000>;
> -		vin-supply = <&vcc_3v3_s3>;
> -	};
> -
>   	vcc_3v3_s0: regulator-3v3-1 {
>   		compatible = "regulator-fixed";
>   		regulator-name = "vcc_3v3_s0";
> @@ -255,7 +245,7 @@ eeprom@50 {
>   		reg = <0x50>;
>   		pagesize = <16>;
>   		read-only;
> -		vcc-supply = <&vcc_3v3_pmu>;
> +		vcc-supply = <&vcc_3v3_s3>;

How about the following instead?

@@ -538,7 +538,7 @@ regulator-state-mem {
 				};
 			};

-			vcc_3v3_s3: dcdc-reg8 {
+			vcc_3v3_pmu: vcc_3v3_s3: dcdc-reg8 {
 				regulator-name = "vcc_3v3_s3";
 				regulator-always-on;
 				regulator-boot-on;

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

>   	};
>   };
>