Re: [PATCH] media: iris: Fix firmware reference leak and unmap memory after load

From: Bryan O'Donoghue
Date: Mon Aug 18 2025 - 07:03:52 EST


On 18/08/2025 12:01, Bryan O'Donoghue wrote:
On 18/08/2025 10:50, Stephan Gerhold wrote:
+    ret = qcom_scm_pas_auth_and_reset(core->iris_platform_data->pas_id);

You're not using the latched pas_id declared @ the top of this function.

With that fixed.

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>

No I'm wrong you've moved this to a separate function.

This patch is fine as-is.

---
bod