Re: [PATCH] NFSD: Drop redundant conversion to bool

From: Jeff Layton
Date: Mon Aug 18 2025 - 07:54:34 EST


On Mon, 2025-08-18 at 18:03 +0800, Xichao Zhao wrote:
> The result of integer comparison already evaluates to bool. No need for
> explicit conversion.
>
> Signed-off-by: Xichao Zhao <zhao.xichao@xxxxxxxx>
> ---
> fs/nfsd/debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/debugfs.c b/fs/nfsd/debugfs.c
> index 84b0c8b559dc..f07d790d56aa 100644
> --- a/fs/nfsd/debugfs.c
> +++ b/fs/nfsd/debugfs.c
> @@ -26,7 +26,7 @@ static int nfsd_dsr_get(void *data, u64 *val)
>
> static int nfsd_dsr_set(void *data, u64 val)
> {
> - nfsd_disable_splice_read = (val > 0) ? true : false;
> + nfsd_disable_splice_read = (val > 0);
> return 0;
> }
>

Sure...

Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>