RE: [PATCH RESEND 1/2] cdx: don't select CONFIG_GENERIC_MSI_IRQ
From: Agarwal, Nikhil
Date: Mon Aug 18 2025 - 08:22:39 EST
> -----Original Message-----
> From: Nipun Gupta <nipun.gupta@xxxxxxx>
> Sent: Monday, August 18, 2025 12:03 PM
> To: arnd@xxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; Agarwal, Nikhil
> <nikhil.agarwal@xxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; llvm@xxxxxxxxxxxxxxx; oe-kbuild-
> all@xxxxxxxxxxxxxxx; robin.murphy@xxxxxxx; krzk@xxxxxxxxxx; tglx@xxxxxxxxxxxxx;
> maz@xxxxxxxxxx; linux@xxxxxxxxxxxxxx; chenqiuji666@xxxxxxxxx;
> peterz@xxxxxxxxxxxxx; robh@xxxxxxxxxx; Gangurde, Abhijit
> <abhijit.gangurde@xxxxxxx>; nathan@xxxxxxxxxx; Arnd Bergmann
> <arnd@xxxxxxxxxx>
> Subject: [PATCH RESEND 1/2] cdx: don't select CONFIG_GENERIC_MSI_IRQ
>
> From: Arnd Bergmann <arnd@xxxxxxxxxx>
>
> x86 does not use CONFIG_GENERIC_MSI_IRQ, and trying to enable it anyway
> results in a build failure:
>
> In file included from include/linux/ssb/ssb.h:10,
> from drivers/ssb/pcihost_wrapper.c:18:
> include/linux/gpio/driver.h:41:33: error: field 'msiinfo' has incomplete type
> 41 | msi_alloc_info_t msiinfo;
> | ^~~~~~~
> In file included from include/linux/kvm_host.h:19,
> from arch/x86/events/intel/core.c:17:
> include/linux/msi.h:528:33: error: field 'alloc_info' has incomplete type
> 528 | msi_alloc_info_t alloc_info;
>
> Change the driver to actually build without this symbol and remove the incorrect
> 'select' statements.
>
> Fixes: e8b18c11731d ("cdx: Fix missing GENERIC_MSI_IRQ on compile test")
> Reviewed-by: Robin Murphy <robin.murphy@xxxxxxx>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxxxx>
Reviewed-by: Nikhil Agarwal <nikhil.agarwal@xxxxxxx>