Re: [PATCH V2] crypto: Mark intermediary memory as clean
From: Herbert Xu
Date: Mon Aug 18 2025 - 08:32:58 EST
On Mon, Aug 18, 2025 at 08:17:17PM +0800, Edward Adam Davis wrote:
>
> Their values are equal, so why use sizeof to calculate?
> Similarly, "if (sizeof(intermediary) != crypto_shash_digestsize(desc->tfm)) {",
> why not just use SHA3_256_DIGEST_SIZE?
Please be consistent with the existing code, every other place
in the function uses sizeof(intermediary) so your patch is the
odd one out.
Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt