Re: [PATCH 2/3] dt-bindings: net: Add support for J-Core EMAC

From: Krzysztof Kozlowski
Date: Mon Aug 18 2025 - 09:52:29 EST


On 18/08/2025 12:57, Geert Uytterhoeven wrote:
>>>
>>> No. It’s a generic IP core for multiple SoCs, which do have names.
>>
>> Then you need other SoCs compatibles, because we do not allow generic
>> items. See writing bindings.
>>
>>> This is the correct naming scheme. All compatible devices and SoCs match properly.
>>
>> No, it is not a correct naming scheme. Please read writing bindings.
>
> Can we please relax this for this specific compatible value?

We can...

> All other devices in this specific hardware implementation were
> accepted without SoC-specific compatible values ca. 9 years ago. AFAIK
> the Ethernet MAC was the sole missing piece, because its Linux driver
> was never attempted to be upstreamed before.

...just provide some context and rationale in the commit msg.

Some (different) people pick up some irrelevant commits and use them as
argument in different discussions in style: it was allowed there, so I
can do the same.

Best regards,
Krzysztof