Re: [PATCH net v4] phy: mscc: Fix timestamping for vsc8584

[Vladimir Oltean]

On Mon, Aug 18, 2025 at 02:53:22PM +0100, Vadim Fedorenko wrote:
> On 18/08/2025 14:21, Vladimir Oltean wrote:
> > On Mon, Aug 18, 2025 at 10:10:29AM +0200, Horatiu Vultur wrote:
> > > diff --git a/drivers/net/phy/mscc/mscc_main.c b/drivers/net/phy/mscc/mscc_main.c
> > > index 37e3e931a8e53..800da302ae632 100644
> > > --- a/drivers/net/phy/mscc/mscc_main.c
> > > +++ b/drivers/net/phy/mscc/mscc_main.c
> > > @@ -2368,6 +2368,13 @@ static int vsc85xx_probe(struct phy_device *phydev)
> > >   	return vsc85xx_dt_led_modes_get(phydev, default_mode);
> > >   }
> > > +static void vsc85xx_remove(struct phy_device *phydev)
> > > +{
> > > +	struct vsc8531_private *priv = phydev->priv;
> > > +
> > > +	skb_queue_purge(&priv->rx_skbs_list);
> > > +}
> > 
> > Have you tested this patch with an unbind/bind cycle? Haven't you found
> > that a call to ptp_clock_unregister() is also missing?
> 
> It was missing before this patch as well, probably needs another patch
> to fix this issue

Sure, separate patch, but the addition I highlighted is pretty obviously
untested.