Re: [PATCH v2 1/2] dt-bindings: rtc: nxp,pcf85363: add timestamp mode config

[Rob Herring (Arm)]

On Mon, 11 Aug 2025 13:51:22 +0530, Lakshay Piplani wrote:
> NXP PCF85263/PCF85363 provides three timestamp registers (TSR1-TSR3)
> which latch the current time when a selected event occurs. Add a
> vendor specific property, nxp,timestamp-mode, to select the event
> source for each register.
> 
> Also introduce a new header 'pcf85363-tsr.h' to expose
> macros for timestamp mode fields, improving readability
> of device tree file.
> 
> Signed-off-by: Lakshay Piplani <lakshay.piplani@xxxxxxx>
> ---
> Changes in v2:
> - Addressed review comments from Rob Herring:
>   * use $ref: /schemas/types.yaml#/definitions/uint32-array
>   * tuple form with exactly 3 items (TSR1/TSR2/TSR3), per items decimal enums
>   * define 'nxp,timestamp-mode' clearly
>   * drop watchdog related vendor properties
>   * remove watchdog related vendor properties from i2c example
> 
>  .../devicetree/bindings/rtc/nxp,pcf85363.yaml | 23 ++++++++++++++-
>  include/dt-bindings/rtc/pcf85363-tsr.h        | 28 +++++++++++++++++++
>  2 files changed, 50 insertions(+), 1 deletion(-)
>  create mode 100644 include/dt-bindings/rtc/pcf85363-tsr.h
> 

Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>