Re: [PATCH net-next v4] ptp: add Alibaba CIPU PTP clock driver
From: Jakub Kicinski
Date: Mon Aug 18 2025 - 12:05:31 EST
On Sat, 16 Aug 2025 11:52:18 +0800 Wen Gu wrote:
> > This driver is lacking documentation. You need to describe how the user
> > is expected to interact with the device and document all these sysfs
> > attributes.
> >
>
> OK. I will add the description.
>
> Would you prefer me to create a related .rst file under Documentation/
> (perhaps in a new Documentation/clock/ptp/ directory?), or add the
> description comments directly in this driver source?
It's supposed to be user-facing documentation, so Documentation.
But you ignored David Woodhouse's response, and also skirted around
Andrew's comment on OS kernel being an abstraction layer. So if you
plan to post a v5 -- the documentation better clearly explain why
this is a PTP device, and not a real time clock.