Re: [PATCH] net: pcs-rzn1-miic: Correct MODCTRL register offset

From: Lad, Prabhakar
Date: Mon Aug 18 2025 - 12:23:54 EST


Hi Andrew,

Thank you for the feedback.

On Mon, Aug 18, 2025 at 4:12 PM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> On Mon, Aug 18, 2025 at 04:07:57PM +0100, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
>
> Please set the Subject: correctly.
>
My bad, I'll take care of this in the next version.

> > Correct the Mode Control Register (MODCTRL) offset for RZ/N MIIC.
> > According to the R-IN Engine and Ethernet Peripherals Manual (Rev.1.30)
> > [0], Table 10.1 "Ethernet Accessory Register List", MODCTRL is at offset
> > 0x8, not 0x20 as previously defined.
>
> What effect does this have? How would i notice it is broken?
>
I will update the commit description.

Cheers,
Prabhakar