Re: [PATCH] perf: pmu: Fix IS_ERR() vs NULL check bug in perf_pmu__init

[Ian Rogers]

On Fri, Aug 15, 2025 at 1:35 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
>
> Hello,
>
> On Tue, Aug 05, 2025 at 10:32:07AM +0400, Miaoqian Lin wrote:
> > Replace NULL check with IS_ERR() check after calling
> > hashmap__new() since this function return error pointers (ERR_PTR).
> > Using NULL check could lead to invalid pointer dereference.
> >
> > Fixes: 754baf426e09 ("perf pmu: Change aliases from list to hashmap")
> > Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>
>
> Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>

Thanks,
Ian