Re: [PATCH] exfat: drop redundant conversion to bool

[Yuezhang.Mo@xxxxxxxx]

> The result of integer comparison already evaluates to bool. No need for
> explicit conversion.
> 
> No functional impact.
> 
> Signed-off-by: Xichao Zhao <zhao.xichao@xxxxxxxx>
> ---
>  fs/exfat/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/exfat/inode.c b/fs/exfat/inode.c
> index c10844e1e16c..f9501c3a3666 100644
> --- a/fs/exfat/inode.c
> +++ b/fs/exfat/inode.c
> @@ -25,7 +25,7 @@ int __exfat_write_inode(struct inode *inode, int sync)
>         struct super_block *sb = inode->i_sb;
>         struct exfat_sb_info *sbi = EXFAT_SB(sb);
>         struct exfat_inode_info *ei = EXFAT_I(inode);
> -       bool is_dir = (ei->type == TYPE_DIR) ? true : false;
> +       bool is_dir = (ei->type == TYPE_DIR);
>         struct timespec64 ts;
> 
>         if (inode->i_ino == EXFAT_ROOT_INO)

The following two if statements both check whether the directory is the root. 
Can we remove the second if statement? I don't know its background.

        if (inode->i_ino == EXFAT_ROOT_INO)
                return 0;

        if (is_dir && ei->dir.dir == sbi->root_dir && ei->entry == -1) 
                return 0;