Re: [PATCH] iio: common: scmi_iio: use kcalloc() instead of kzalloc()

[Andy Shevchenko]

On Tue, Aug 19, 2025 at 11:56 AM Qianfeng Rong <rongqianfeng@xxxxxxxx> wrote:
>
> Replace calls of devm_kzalloc() with devm_kcalloc() in scmi_alloc_iiodev()
> and scmi_iio_set_sampling_freq_avail() for safer memory allocation with
> built-in overflow protection.

While this change is correct...

...

>         sensor->freq_avail =
> -               devm_kzalloc(&iio_dev->dev,
> -                            sizeof(*sensor->freq_avail) *
> -                                    (sensor->sensor_info->intervals.count * 2),
> +               devm_kcalloc(&iio_dev->dev,
> +                            sensor->sensor_info->intervals.count * 2,

...I would also switch this to use array_size() instead of explicit
multiplication as it will check for boundaries that are not static in
this case.

> +                            sizeof(*sensor->freq_avail),
>                              GFP_KERNEL);
>         if (!sensor->freq_avail)
>                 return -ENOMEM;

-- 
With Best Regards,
Andy Shevchenko