Re: [PATCH net-next v2 3/8] net: dsa: lantiq_gswip: move definitions to header

[Vladimir Oltean]

On Tue, Aug 19, 2025 at 02:33:02AM +0100, Daniel Golle wrote:
> +#define GSWIP_TABLE_ACTIVE_VLAN		0x01
> +#define GSWIP_TABLE_VLAN_MAPPING	0x02
> +#define GSWIP_TABLE_MAC_BRIDGE		0x0b
> +#define  GSWIP_TABLE_MAC_BRIDGE_KEY3_FID	GENMASK(5, 0)	/* Filtering identifier */
> +#define  GSWIP_TABLE_MAC_BRIDGE_VAL0_PORT	GENMASK(7, 4)	/* Port on learned entries */
> +#define  GSWIP_TABLE_MAC_BRIDGE_VAL1_STATIC	BIT(0)		/* Static, non-aging entry */
> +#define  GSWIP_TABLE_MAC_BRIDGE_VAL1_VALID	BIT(1)		/* Valid bit */

The VAL1_VALID bit definition sneaked in, there was no such thing in the
code being moved.

I'm willing to let this pass (I don't think I have other review comments
that would justify a resend), but it's not a good practice to introduce
changes in large quantities of code as you're moving them around.