Re: [PATCH 2/5] firmware: stratix10-svc: Implement ID pool management for asynchronous operations

From: Greg KH
Date: Tue Aug 19 2025 - 07:09:46 EST


On Tue, Jul 22, 2025 at 11:30:42AM -0500, Dinh Nguyen wrote:
> From: Mahesh Rao <mahesh.rao@xxxxxxxxxx>
>
> Implement ID pool management API's which will be
> used for Stratix10 Asynchronous communication with
> Secure Device Manager. These API's will be used
> in subsequent patches for ID management in
> asynchronous operations.

Please don't "roll your own" id management. Use the idr data structure
instead. It's simple, it works, and we don't have to review your
hand-made version :)

thanks,

greg k-h