Re: [PATCH RESEND] rust: fs: update ARef and AlwaysRefCounted imports from sync::aref
From: Christian Brauner
Date: Tue Aug 19 2025 - 07:29:01 EST
On Thu, Aug 14, 2025 at 03:31:01PM +0530, Shankari Anand wrote:
> Update call sites in the fs subsystem to import `ARef` and
> `AlwaysRefCounted` from `sync::aref` instead of `types`.
>
> This aligns with the ongoing effort to move `ARef` and
> `AlwaysRefCounted` to sync.
>
> Suggested-by: Benno Lossin <lossin@xxxxxxxxxx>
> Link: https://github.com/Rust-for-Linux/linux/issues/1173
> Acked-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
> Signed-off-by: Shankari Anand <shankari.ak0208@xxxxxxxxx>
> ---
> It part of a subsystem-wise split series, as suggested in:
> https://lore.kernel.org/rust-for-linux/CANiq72=NSRMV_6UxXVgkebmWmbgN4i=sfRszr-G+x3W5A4DYOg@xxxxxxxxxxxxxx/T/#u
> This split series is intended to ease review and subsystem-level maintenance.
>
> The original moving patch is here: (commit 07dad44aa9a93)
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=07dad44aa9a93b16af19e8609a10b241c352b440
>
> Gradually the re-export from types.rs will be eliminated in the
> future cycle.
>
> (Carry-forwarded acked-by tag and added Christian and Alexander as recipient)
> ---
I think it would be nice if we could get all fs related patches sent to
fsdevel so list-only subscribers get them. :)
> rust/kernel/fs/file.rs | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/rust/kernel/fs/file.rs b/rust/kernel/fs/file.rs
> index 35fd5db35c46..18cf579d3312 100644
> --- a/rust/kernel/fs/file.rs
> +++ b/rust/kernel/fs/file.rs
> @@ -11,7 +11,8 @@
> bindings,
> cred::Credential,
> error::{code::*, Error, Result},
> - types::{ARef, AlwaysRefCounted, NotThreadSafe, Opaque},
> + sync::aref::{ARef, AlwaysRefCounted},
> + types::{NotThreadSafe, Opaque},
> };
> use core::ptr;
>
> --
> 2.34.1
>