Re: [PATCH 1/3] mpage: terminate read-ahead on read error

From: Chi Zhiling
Date: Tue Aug 19 2025 - 08:31:29 EST


On 2025/8/18 22:33, Matthew Wilcox wrote:
On Mon, Aug 18, 2025 at 06:04:23PM +0800, Chi Zhiling wrote:
Also, boy this is old code. Basically akpm code from pre-git times.
It was quite innovative back then, but everybody who understood it has
since moved on, got senile or probably died. Oh well.

Actually, I think this patch is safe, but I'm not sure if we should fix this
issue. After all, this code has existed for a long time, and it's quite rare
to unplug the device during a copy operation :)

Converting exfat to use iomap would be a valuable piece of work ...

Yes, this is indeed worthwhile, and exFAT should also be restructured to support extents rather than fetching entries one by one.

I estimate this would bring significant performance improvements


Thanks,
Chi Zhiling