RE: [PATCH v4 net-next 05/15] ptp: netc: add PTP_CLK_REQ_PPS support

[Wei Fang]

> > +static int netc_timer_init_msix_irq(struct netc_timer *priv) {
> > +	struct pci_dev *pdev = priv->pdev;
> > +	char irq_name[64];
> > +	int err, n;
> > +
> > +	n = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_MSIX);
> > +	if (n != 1) {
> > +		err = (n < 0) ? n : -EPERM;
> > +		dev_err(&pdev->dev, "pci_alloc_irq_vectors() failed\n");
> > +		return err;
> > +	}
> > +
> > +	priv->irq = pci_irq_vector(pdev, 0);
> > +	snprintf(irq_name, sizeof(irq_name), "ptp-netc %s", pci_name(pdev));
> > +	err = request_irq(priv->irq, netc_timer_isr, 0, irq_name, priv);
> 
> https://elixir.bootlin.com/linux/v6.11.7/source/kernel/irq/manage.c#L2109
> 
> request_irq can't copy irq_name, so irq_name is out of scope after
> netc_timer_init_msix_irq() return.
> 
> cat /proc/interrupt will show garbage string for ptp timer.
> 
> use devm_kasprintf().
> 

Thanks, I will fix this issue.