Re: [PATCH net-next v2 2/3] net: stmmac: xgmac: Correct supported speed modes

From: G Thomas, Rohan
Date: Wed Aug 20 2025 - 02:57:42 EST


Hi Jakub,

Thanks for reviewing the patch.

On 8/20/2025 6:49 AM, Jakub Kicinski wrote:
On Sat, 16 Aug 2025 00:55:24 +0800 Rohan G Thomas via B4 Relay wrote:
{
u32 hw_cap;
+ struct stmmac_priv *priv = container_of(dma_cap, struct stmmac_priv,
+ dma_cap);
+
/* MAC HW feature 0 */

nit: no empty lines between variable declarations and longest to
shortest, so:

Sure, will fix this in the next version.


{
+ struct stmmac_priv *priv = container_of(dma_cap, struct stmmac_priv,
+ dma_cap);
u32 hw_cap;

Best Regards,
Rohan