Re: [PATCH v2] pwm: berlin: Fix wrong register in suspend/resume

[Uwe Kleine-König]

Hello,

On Tue, Aug 19, 2025 at 07:42:24PM +0800, Jisheng Zhang wrote:
> The 'enable' register should be BERLIN_PWM_EN rather than
> BERLIN_PWM_ENABLE, otherwise, the driver accesses wrong address, there
> will be cpu exception then kernel panic during suspend/resume.
> 
> Fixes: bbf0722c1c66 ("pwm: berlin: Add suspend/resume support")
> Signed-off-by: Jisheng Zhang <jszhang@xxxxxxxxxx>
> ---
> since v1:
>  - update commit log to mention cpu exception then kernel panic w/o
>    the patch

Applied this patch to

https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/fixes

with a Cc: stable now. Given this issue is nearly 9 years old I'm not
sure yet this fix is urgent enough to justify a fixes PR to Linus.

However there are two such patches now, so maybe I will prepare another
pull request before 6.17. But for now I will give it a few days in next
first.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature