Re: [PATCH v3] rust: alloc: implement Box::pin_slice()
From: Danilo Krummrich
Date: Wed Aug 20 2025 - 08:57:58 EST
On Wed Aug 20, 2025 at 10:07 AM CEST, Vitaly Wool wrote:
> On 8/11/25 12:14, Vitaly Wool wrote:
>> From: Alice Ryhl <aliceryhl@xxxxxxxxxx>
>>
>> Add a new constructor to Box to facilitate Box creation from a pinned
>> slice of elements. This allows to efficiently allocate memory for e.g.
>> slices of structrures containing spinlocks or mutexes. Such slices may
>> be used in kmemcache like or zpool API implementations.
>>
>> Signed-off-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
>> Signed-off-by: Vitaly Wool <vitaly.wool@xxxxxxxxxxx>
>
> From what I could see, there were no objections to this one. Danilo,
> would you be up for picking it or is there something missing about it still?
This looks good now.
There's a few minor nits, e.g. it'd be nice to have an empty line between
struct definitions in the example and sentences ending with a period. But I can
fix those up on apply.