Re: [PATCH] staging: media: atomisp: Whitespaces style cleanup in gdc.c

From: Dan Carpenter
Date: Wed Aug 20 2025 - 09:04:30 EST


On Wed, Aug 20, 2025 at 12:45:19PM +0000, Adrian Barnaś wrote:
> NFC: This patch cleans up coding style whitespace issues

What does "NFC" mean in this context? I only know it as the networking
protocol.

> in drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c
>
> Fixes include:
> - removal of unnecessary line breaks
> - correcting spacing around operators
> - correcting spaces between types and names
>
> Signed-off-by: Adrian Barnaś <abarnas@xxxxxxxxxx>
> ---

[ snip ]

> @@ -85,8 +79,7 @@ void gdc_lut_convert_to_isp_format(const int in_lut[4][HRT_GDC_N],
> }
> }
>
> -int gdc_get_unity(
> - const gdc_ID_t ID)
> +int gdc_get_unity(const gdc_ID_t ID)
> {
> assert(ID < N_GDC_ID);
> (void)ID;
> @@ -96,10 +89,8 @@ int gdc_get_unity(
> /*
> * Local function implementations
> */
> -static inline void gdc_reg_store(
> - const gdc_ID_t ID,
> - const unsigned int reg,
> - const hrt_data value)
> +static inline void gdc_reg_store(const gdc_ID_t ID, const unsigned int reg,
^^^^^^^
Replace this tab with a space.



> + const hrt_data value)
> {
> ia_css_device_store_uint32(GDC_BASE[ID] + reg * sizeof(hrt_data), value);
> return;

regards,
dan carpenter