Re: [PATCH] staging: media: atomisp: Whitespaces style cleanup in gdc.c

From: Andy Shevchenko
Date: Wed Aug 20 2025 - 09:08:10 EST


On Wed, Aug 20, 2025 at 12:45:19PM +0000, Adrian Barnaś wrote:
> NFC: This patch cleans up coding style whitespace issues
> in drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c
>
> Fixes include:
> - removal of unnecessary line breaks
> - correcting spacing around operators
> - correcting spaces between types and names

...

> -static inline void gdc_reg_store(
> - const gdc_ID_t ID,
> - const unsigned int reg,
> - const hrt_data value);
> +static inline void gdc_reg_store(const gdc_ID_t ID, const unsigned int reg,
> + const hrt_data value);

Can you rather refactor code to get rid of the forward declaration?

...

> +static inline void gdc_reg_store(const gdc_ID_t ID, const unsigned int reg,

This still is wrong, shouldn't be any tabs here.

> + const hrt_data value)

--
With Best Regards,
Andy Shevchenko