Re: [PATCH v3 1/6] dt-bindings: mfd: twl: Add missing sub-nodes for TWL4030 & TWL603x

[Jihed Chaibi]

On Wed, Aug 20, 2025 at 7:57 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On 19/08/2025 22:31, Andreas Kemnade wrote:
> >>
> >>> +          type: object
> >>> +          $ref: /schemas/usb/ti,twlxxxx-usb.yaml#
> >>
> >> Are you sure your patchset is bsiectable? Apply this patch and test. You
> >> will see errors and you must fix these. Even after fixing you have
> >> strict dependencies so your cover letter must explain these (or merging
> >> constraints)...
> >>
> > what are the rules here regarding bisectability? non-existing files
>
> dt_binding_check.
>
>
> Best regards,
> Krzysztof

Hello Krzysztof and Andreas,

Thanks again for your feedback,

You were right that my series had strict dependencies. Testing again I
found that a
local 'dt_binding_check' -only including this patch- passed, but the
dependencies
(non-existent yaml files in $ref) caused errors during a full 'dtbs_check'.

I managed to fix those dtbs_check warnings/errors thanks to
'additionalProperties: true'
to break the hard dependencies on the other new YAML files, and by
adding optional
definitions for the 'clocks' and 'clock-names' properties, which I
found are used by several
OMAP dts files.

Please let me know what you think of this, and whether I should send the new,
corrected v4 of this MFD (single) patch.

I have already sent the independent v4 patches for the other
subsystems (ASoC, USB, etc.).
in order to reach a much better orthogonality and independence between
the patches.

Thanks again for your guidance.
Best regards,

Jihed