Re: [PATCH v4 3/3] iio: pressure: bmp280: Use gpiod_set_value_cansleep()

From: Andy Shevchenko
Date: Wed Aug 20 2025 - 10:52:28 EST


On Mon, Aug 18, 2025 at 10:27:32AM +0100, Salah Triki wrote:
> Switch to `gpiod_set_value_cansleep()`, which is safe to use in
> sleepable contexts like the driver probe function.

The commit message is unclear on why? aspect. You need to elaborate that some
GPIO chips may be located behind slow (and hence sleepable) busses, such as
I²C).

Code wise I agree with the change.
With amended commit message
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

--
With Best Regards,
Andy Shevchenko