Re: [PATCH net-next v6 2/5] net: spacemit: Add K1 Ethernet MAC
From: Vivian Wang
Date: Wed Aug 20 2025 - 13:49:26 EST
Hi Maxime,
On 8/20/25 19:34, Maxime Chevallier wrote:
> Hi Vivian,
>
> On 20/08/2025 08:47, Vivian Wang wrote:
>> The Ethernet MACs found on SpacemiT K1 appears to be a custom design
>> that only superficially resembles some other embedded MACs. SpacemiT
>> refers to them as "EMAC", so let's just call the driver "k1_emac".
>>
>> Supports RGMII and RMII interfaces. Includes support for MAC hardware
>> statistics counters. PTP support is not implemented.
>>
>> Tested-by: Junhui Liu <junhui.liu@xxxxxxxxxxxxx>
>> Signed-off-by: Vivian Wang <wangruikang@xxxxxxxxxxx>
>
> I've read through the driver and it's looking good to me
>
> Reviewed-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>
>
Thank you for the review. I appreciate it.
Vivian "dramforever" Wang