Re: [PATCH v2 2/2] usb: typec: maxim_contaminant: re-enable cc toggle if cc is open and port is clean

From: Heikki Krogerus
Date: Thu Aug 21 2025 - 03:16:04 EST


One nitpick...

> @@ -345,6 +378,12 @@ bool max_contaminant_is_contaminant(struct max_tcpci_chip *chip, bool disconnect
> if (ret < 0)
> return false;
>
> + if (cc_status & TCPC_CC_STATUS_TOGGLING) {
> + if (chip->contaminant_state == DETECTED)
> + return true;
> + return false;
> + }

if (cc_status & TCPC_CC_STATUS_TOGGLING) {
return chip->contaminant_state == DETECTED;

> if (chip->contaminant_state == NOT_DETECTED || chip->contaminant_state == SINK) {
> if (!disconnect_while_debounce)
> msleep(100);

thanks,

--
heikki