Re: [net-next v5 1/3] dt-bindings: net: dsa: yt921x: Add Motorcomm YT921x switch support

[Krzysztof Kozlowski]

On Wed, Aug 20, 2025 at 03:54:14PM +0800, David Yang wrote:
> The Motorcomm YT921x series is a family of Ethernet switches with up to
> 8 internal GbE PHYs and up to 2 GMACs.

Please use standard email subjects, so with the PATCH keyword in the
title. 'git format-patch -vX' helps here to create proper versioned patches.
Another useful tool is b4. Skipping the PATCH keyword makes filtering of
emails more difficult thus making the review process less convenient.

> 
> Signed-off-by: David Yang <mmyangfl@xxxxxxxxx>
> ---
>  .../bindings/net/dsa/motorcomm,yt921x.yaml    | 150 ++++++++++++++++++
>  1 file changed, 150 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/dsa/motorcomm,yt921x.yaml

...

> +  mdio-external:
> +    $ref: /schemas/net/mdio.yaml#
> +    unevaluatedProperties: false
> +    description: |
> +      External MDIO bus to access external components. External PHYs for GMACs
> +      (Port 8-9) are expected to be connected to the external MDIO bus in
> +      vendor's reference design, but that is not a hard limitation from the
> +      chip.
> +
> +allOf:

This goes after required: block.

But don't resend just for that.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof