Re: [PATCH net-next] amd-xgbe: Add PPS periodic output support

[Paolo Abeni]

On 8/18/25 1:58 PM, Raju Rangoju wrote:
> @@ -122,6 +148,8 @@ void xgbe_ptp_register(struct xgbe_prv_data *pdata)
>  	info->adjtime = xgbe_adjtime;
>  	info->gettimex64 = xgbe_gettimex;
>  	info->settime64 = xgbe_settime;
> +	info->n_per_out = pdata->hw_feat.pps_out_num;
> +	info->n_ext_ts = pdata->hw_feat.aux_snap_num;

Both pps_out_num and aux_snap_num are read from 3 bits out of a
register, and I don't see any check to prevent such values exceeding the
limit hardcoded below (4). Why don't you need some additional sanity check?

Thanks,

Paolo