Re: [PATCH v9 05/19] KVM: selftests: Update kvm_init_vm_address_properties() for TDX

[Ira Weiny]

Sagi Shahar wrote:
> From: Isaku Yamahata <isaku.yamahata@xxxxxxxxx>
> 
> Let kvm_init_vm_address_properties() initialize vm->arch.{s_bit, tag_mask}
> similar to SEV.
> 
> TDX sets the shared bit based on the guest physical address width and
> currently supports 48 and 52 widths.
> 
> Co-developed-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> Signed-off-by: Isaku Yamahata <isaku.yamahata@xxxxxxxxx>
> Co-developed-by: Sagi Shahar <sagis@xxxxxxxxxx>
> Signed-off-by: Sagi Shahar <sagis@xxxxxxxxxx>
> ---
>  .../selftests/kvm/include/x86/tdx/tdx_util.h       | 14 ++++++++++++++
>  tools/testing/selftests/kvm/lib/x86/processor.c    | 12 ++++++++++--
>  2 files changed, 24 insertions(+), 2 deletions(-)
>  create mode 100644 tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h
> 
> diff --git a/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h b/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h
> new file mode 100644
> index 000000000000..286d5e3c24b1
> --- /dev/null
> +++ b/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h
> @@ -0,0 +1,14 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +#ifndef SELFTESTS_TDX_TDX_UTIL_H
> +#define SELFTESTS_TDX_TDX_UTIL_H
> +
> +#include <stdbool.h>
> +
> +#include "kvm_util.h"
> +
> +static inline bool is_tdx_vm(struct kvm_vm *vm)
> +{
> +	return vm->type == KVM_X86_TDX_VM;
> +}

NIT: Might have been better to define this in 4/19 and use it there.  But
looks like that logic is changed later on somewhere.  So...  meh.

Ira

[snip]