Re: [RESEND PATCH v7 1/1] PCI/sysfs: Expose PCIe device serial number

From: Keith Busch
Date: Thu Aug 21 2025 - 20:05:38 EST


On Thu, Aug 21, 2025 at 04:22:38PM -0700, Matthew Wood wrote:
> Add a single sysfs read-only interface for reading PCIe device serial
> numbers from userspace in a programmatic way. This device attribute
> uses the same hexadecimal 1-byte dashed formatting as lspci serial number
> capability output. If a device doesn't support the serial number
> capability, the serial_number sysfs attribute will not be visible.

Looks good to me.

Reviewed-by: Keith Busch <kbusch@xxxxxxxxxx>