Re: Re: Re: Re: Re: Re: Re: [PATCH v3 2/2] ethernet: eswin: Add eic7700 ethernet driver

[李志]

Dear Andrew Lunn,
Thank you for your valuable and professional suggestions.
Please find our explanations embedded below your comments in the
original email.

Best regards,

Li Zhi
Eswin Computing


> -----原始邮件-----
> 发件人: "Andrew Lunn" <andrew@xxxxxxx>
> 发送时间:2025-08-22 11:17:37 (星期五)
> 收件人: 李志 <lizhi2@xxxxxxxxxxxxxxxxxx>
> 抄送: weishangjuan@xxxxxxxxxxxxxxxxxx, andrew+netdev@xxxxxxx, davem@xxxxxxxxxxxxx, edumazet@xxxxxxxxxx, kuba@xxxxxxxxxx, robh@xxxxxxxxxx, krzk+dt@xxxxxxxxxx, conor+dt@xxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, mcoquelin.stm32@xxxxxxxxx, alexandre.torgue@xxxxxxxxxxx, rmk+kernel@xxxxxxxxxxxxxxx, yong.liang.choong@xxxxxxxxxxxxxxx, vladimir.oltean@xxxxxxx, jszhang@xxxxxxxxxx, jan.petrous@xxxxxxxxxxx, prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx, inochiama@xxxxxxxxx, boon.khai.ng@xxxxxxxxxx, dfustini@xxxxxxxxxxxxxxx, 0x1207@xxxxxxxxx, linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, ningyu@xxxxxxxxxxxxxxxxxx, linmin@xxxxxxxxxxxxxxxxxx, pinkesh.vaghela@xxxxxxxxxxxxxx
> 主题: Re: Re: Re: Re: Re: Re: [PATCH v3 2/2] ethernet: eswin: Add eic7700 ethernet driver
> 
> > We re-tuned and verified that setting the TXD and RXD delays to 0 and
> > configuring TXEN and RXDV to 0 yielded the same hardware performance as
> > long as we only applied delays (e.g. 200ps) to TXCLK and RXCLK.
> 
> This is in addition to phy-mode = 'rgmii-id'?
> 

Yes, our re-tuning and verification were performed with phy-mode set to
rgmii-id.

> > Therefore, in the next patch, we will drop the vendor-specific properties
> > (e.g. eswin,dly-param-*) and keep only the standard attributes, namely
> > rx-internal-delay-ps and tx-internal-delay-ps.
> > Is this correct?
> 
> Yes, 200ps is a small tuning value, when the PHY adds the 2ns. This is
> O.K.
> 
> 	Andrew