Re: [PATCH v4] mm/zswap: store <PAGE_SIZE compression failed page as-is
From: Herbert Xu
Date: Fri Aug 22 2025 - 01:55:02 EST
On Fri, Aug 22, 2025 at 12:48:27PM +1200, Barry Song wrote:
>
> Is it even possible for crypto_wait_req() to return -EINPROGRESS, since
> crypto_req_done() will not call complete(&wait->completion) in that case at
> all?
Of course crypto_wait_req cannot return -EINPROGRESS. However,
I was responding to a request to make the crypto_acomp_compress
call return a boolean instead of an error code. That is not
possible because it has to be able to return -EINPROGRESS.
Nor is it possible to change crypto_wait_req to be boolean since
other Crypto API operations (including decompression) can indeed
fail.
Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt