RE: [PATCH v2 net-next 5/5] net: fec: enable the Jumbo frame support for i.MX8QM

[Wei Fang]

> @@ -481,6 +483,11 @@ fec_enet_create_page_pool(struct fec_enet_private
> *fep,
>  	};
>  	int err;
> 
> +	if (fep->pagepool_order != 0) {
> +		pp_params.order = fep->pagepool_order;
> +		pp_params.max_len = fep->rx_frame_size;
> +	}
> +

We can move this logic to the initialization of pp_params, just as follows.

struct page_pool_params pp_params = {
		.order = fep->pagepool_order,
		[...]
		.max_len = fep->rx_frame_size,
};

A question: shouldn't this change be in the 4th patch ("net: fec: add change
mtu to support dynamic buffer allocation") ?