Re: [PATCH] crypto: octeontx2 - Call strscpy() with correct size argument

From: Herbert Xu
Date: Fri Aug 22 2025 - 05:38:20 EST


On Mon, Aug 11, 2025 at 11:24:57AM +0200, Thorsten Blum wrote:
> In otx2_cpt_dl_custom_egrp_create(), strscpy() is called with the length
> of the source string rather than the size of the destination buffer.
>
> This is fine as long as the destination buffer is larger than the source
> string, but we should still use the destination buffer size instead to
> call strscpy() as intended. And since 'tmp_buf' is a fixed-size buffer,
> we can safely omit the size argument and let strscpy() infer it using
> sizeof().
>
> Fixes: d9d7749773e8 ("crypto: octeontx2 - add apis for custom engine groups")
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
> ---
> drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt